Add handling of for_static parameter #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
force-pushed
the
add-for-static-parameter
branch
from
d3204e3
to
85bf577
Compare
KludgeKML
force-pushed
the
add-for-static-parameter
branch
from
85bf577
to
75ea1eb
Compare
andysellick
approved these changes
Nov 7, 2024
KludgeKML
force-pushed
the
add-for-static-parameter
branch
4 times, most recently
from
1323959
to
f670c0f
Compare
- original behaviour was to always include wrapper class unless show_account_layout or custom_layout was present (custom layout is as of yet not used). Alter behaviour so that default is not to have the wrapper, and it's only included if for_static is true. - Update examples - Note that this is likely to cause a number of visual regressions in the test suite as only some of the examples have the for_static: true flag set. - The visual regression tester currently relies on the wrapper being present to take its screenshot, so we add the for_static: true flag to the layout in the dummy app.
KludgeKML
force-pushed
the
add-for-static-parameter
branch
from
f670c0f
to
743018a
Compare
|
Have approved the Percy visual regression - it's one added example (with the for_static parameter), then the other examples getting shrunk slightly because they don't have the for_static: true flag set, so they are missing the wrappers and main elements (the point of this PR). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
layout_for_public does not behave like a standard layout - it's default is to include a wrapper element which is cut out by slimmer and replaced with the wrapper from the client app. If we try to use layout_for_public directly, this results in a double wrapper (or a single wrapper, but without the ability to add classes to it). Adding a parameter which maintains this behaviour (which can be added in Static: alphagov/static#3440 ), but defaulting to not including the wrapper element allows other apps to use the layout component directly.
https://trello.com/c/COQYfYgn/347-allow-layoutforpublic-to-work-like-a-normal-layout
Visual Changes
None expected