Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for app-publishing-amazonmq migration #1456

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

samsimpson1
Copy link
Member

This PR does 2 things necessary for app-publishing-amazonmq to be migrated from govuk-aws:

  • Outputs root zone IDs in the vpc module
  • Adds a new var set for amazonmq in integration. This was done because its adding a lot of variables that aren't used in any other deployment

The terraform test for tfc-configuration will fail because TF expects a var set to exist before being added to a workspace, and this PR does both the creation and assigning.

#1127

@samsimpson1 samsimpson1 requested a review from a team October 3, 2024 12:31
@samsimpson1 samsimpson1 merged commit fdef615 into main Oct 3, 2024
4 of 5 checks passed
@samsimpson1 samsimpson1 deleted the samsimpson1/amazonmq branch October 3, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants