Updating Clam config and clamdscan path #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes paths for Staging and Production:
New clam config has been tested in integration - by uploading asset on
Whitehall and then checking logs to see virus scan completed and asset
added to AWS S3.
helm template asset-clam ../asset-manager --values <(helm template . --values values-production.yaml | yq e '.|select(.metadata.name == "asset-manager").spec.source.helm.values') --set sentry.createSecret=false
Output for Prod mount:
volumeMounts:
- name: etc-clamav
mountPath: /usr/local/etc
helm template asset-clam ../asset-manager --values <(helm template . --values values-staging.yaml | yq e '.|select(.metadata.name == "asset-manager").spec.source.helm.values') --set sentry.createSecret=false
Output for staging mount:
volumeMounts:
- name: etc-clamav
mountPath: /usr/local/etc
https://trello.com/c/TicAq9G1/1238-update-clamav-engine-to-latest-version
sengi
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes paths for Staging and Production:
New ClamAV config and engine 1.2.1 has been tested in integration - Uploading asset on Whitehall, then checking logs to see virus scan completed and asset added to AWS S3.
Pre req:(this code should be merged after)
alphagov/asset-manager#1248
Tested output of change via helm template:
helm template asset-clam ../asset-manager --values <(helm template . --values values-${ENV}| yq e '.|select(.metadata.name == "asset-manager").spec.source.helm.values') --set sentry.createSecret=falseOutput for Prod mount:
Output for Staging mount:
https://trello.com/c/TicAq9G1/1238-update-clamav-engine-to-latest-version