Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ckan domain find #310

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix ckan domain find #310

merged 2 commits into from
Oct 4, 2024

Conversation

kentsanggds
Copy link
Collaborator

@kentsanggds kentsanggds commented Oct 3, 2024

Would default to ckan.publishing.service.gov.uk without these settings.

@kentsanggds kentsanggds requested a review from a team October 3, 2024 17:01
Copy link
Contributor

@AgaDufrat AgaDufrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Added a minor comment around duplicated keys in values-integration.

@@ -112,6 +112,8 @@ datagovukHelmValues:
"www.integration.data.gov.uk",
"integration.data.gov.uk"
]}}]
config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add it under the config key defined on line 93?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, will move it

@kentsanggds kentsanggds merged commit 5a29d69 into main Oct 4, 2024
1 check passed
@kentsanggds kentsanggds deleted the fix-ckanDomain-find branch October 4, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants