Upgrade to Debian Stable and Ruby 3.2 #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably want to upgrade the GHA config to use Ruby 3.2 and ubuntu-24.04 |
benjamineskola
force-pushed
the
ruby-3.2
branch
6 times, most recently
from
4f97a54
to
912da6f
Compare
|
All the errors seem related to the Active Storage image on the debate outcome models |
I can't reproduce this locally (in docker) — wondering if there's some difference between Debian and Ubuntu? |
pixeltrix
approved these changes
Jun 6, 2024
| - name: Install image processing tools | ||
| shell: bash | ||
| run: | | ||
| sudo apt-get -yqq install imagemagick libvips |
There was a problem hiding this comment.
Interesting this is not in the default setup - seems to be a change in the 24.04 runner vs the 22.04 runner
There was a problem hiding this comment.
Yes, I'm not sure what the underlying change is — perhaps it was previously pulled in as a dependency by something else? Can't hurt to be explicit about it everywhere though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.