Remove caching of CSV responses #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These responses are too large to fit within memcached and should be cached in the CDN.
We are using the default packages from Ubuntu 22.04 which will be supported until April 2027.
Logged in state was leaking between examples.
The Facebook crawler sees the url in a CSV response and attempts to follow it but includes the signature counts in the line as the comma is not detected as the end of the url. By quoting the string columns (action, url and state) it should help badly designed crawlers detect the end of the url and reduce the spikes of "400 Bad Request" errors we get.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These responses are too large to fit within memcached and should be cached in the CDN.