Bump rubocop-govuk from 4.18.0 to 5.0.1 #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) from 4.18.0 to 5.0.1. - [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md) - [Commits](alphagov/rubocop-govuk@v4.18.0...v5.0.1) --- updated-dependencies: - dependency-name: rubocop-govuk dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs. |
We were comparing the same value with the same expected value. Updating to correct this. Fixed rubocop failure `RSpec/IdenticalEqualityAssertion`.
This fixes the rubocop failure `RSpec/IndexedLet`.
brucebolt
force-pushed
the
dependabot/bundler/rubocop-govuk-5.0.1
branch
from
7d641b7 to
7812a12
Compare
sengi
approved these changes
Jun 27, 2024
|
Thanks for the cleanup ❤️ |
yndajas
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-govuk from 4.18.0 to 5.0.1.
Changelog
Sourced from rubocop-govuk's changelog.
Commits
a1e3489Merge pull request #400 from alphagov/kevindew-patch-1e46452aRelease 5.0.11c1ed2aDisable RSpec/NoExpectationExample for feature/system specs6f199edMerge pull request #393 from alphagov/new-release3cfe11cRelease 5.0.0f176db6Update RSpec/Dialect config993ffa7Move RSpec/Dialect config to rspec.yml57aaeedMerge pull request #392 from alphagov/dependabot/bundler/rubocop-rspec-eq-3.0.14ec3e56Add Capybara which was extracted from rubocop-rspec9a277a8Use 'RSpec/Dialect' instead of 'RSpec/Capybara/FeatureMethods'Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)