Symlink the new AV path to avoid breakages. #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj-maisy
force-pushed
the
dj-maisy/clamav-bin-symlink
branch
from
307fcfc to
ab50f47
Compare
sengi
approved these changes
Jun 19, 2024
Dockerfile
Outdated
Comment on lines
137
to
143
| RUN ln -s /usr/bin/clamav-config /usr/local/bin/clamav-config && \ | ||
| ln -s /usr/bin/clambc /usr/local/bin/clambc && \ | ||
| ln -s /usr/bin/clamconf /usr/local/bin/clamconf && \ | ||
| ln -s /usr/bin/clamdscan /usr/local/bin/clamdscan && \ | ||
| ln -s /usr/bin/clamdtop /usr/local/bin/clamdtop && \ | ||
| ln -s /usr/bin/clamscan /usr/local/bin/clamscan && \ | ||
| ln -s /usr/bin/clamsubmit /usr/local/bin/clamsubmit && \ |
There was a problem hiding this comment.
How about:
Suggested change
| RUN ln -s /usr/bin/clamav-config /usr/local/bin/clamav-config && \ | |
| ln -s /usr/bin/clambc /usr/local/bin/clambc && \ | |
| ln -s /usr/bin/clamconf /usr/local/bin/clamconf && \ | |
| ln -s /usr/bin/clamdscan /usr/local/bin/clamdscan && \ | |
| ln -s /usr/bin/clamdtop /usr/local/bin/clamdtop && \ | |
| ln -s /usr/bin/clamscan /usr/local/bin/clamscan && \ | |
| ln -s /usr/bin/clamsubmit /usr/local/bin/clamsubmit && \ | |
| RUN ln -s /usr/bin/clam* /usr/local/bin && \ |
Dockerfile
Outdated
| ln -s /usr/bin/clamdtop /usr/local/bin/clamdtop && \ | ||
| ln -s /usr/bin/clamscan /usr/local/bin/clamscan && \ | ||
| ln -s /usr/bin/clamsubmit /usr/local/bin/clamsubmit && \ | ||
| chmod 0755 /usr/local/bin/clam* |
There was a problem hiding this comment.
This changes the mode of the link targets rather than the links themselves. Is that what you intend here? (and have you checked that it's necessary?)
|
It'd also be cool to fix the app not to specify the full path so that we can remove this workaround later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The new build process leaves the various ClamAV binaries in
/usr/bin, whereas they were previously linked to/usr/local/bin. Let's symlink these binaries so they can still be found in the right place by Asset Manager.