Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial: standardise on netcat-openbsd. #1406

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Trivial: standardise on netcat-openbsd. #1406

merged 1 commit into from
Jun 19, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Jun 18, 2024

Shouldn't matter much but might as well keep this consistent (both with what we used to install under 22.04 and with what's in govuk-infrastructure/toolbox).

The OpenBSD implementation lacks -e (which is a plus) and is a bit more modern and actively maintained.

netcat is used in the healthcheck script in the underlying clamav container.

Shouldn't matter much but might as well keep this consistent (both with
what we used to install under 22.04 and with what's in
govuk-infrastructure/toolbox).

The OpenBSD implementation lacks `-e` (which is a plus) and is a bit
more modern and actively maintained.

netcat is used in the healthcheck script in the underlying clamav
container:
https://github.com/Cisco-Talos/clamav-docker/blob/main/clamav/1.3/debian/scripts/clamdcheck.sh
@sengi sengi requested a review from dj-maisy June 18, 2024 11:30
@dj-maisy dj-maisy merged commit 2a00d90 into main Jun 19, 2024
10 checks passed
@dj-maisy dj-maisy deleted the sengi/netcat branch June 19, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants