Add logging to help diagnose ongoing issue with virus scanning #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an ongoing issue where we are seeing the following errors related to
missing files coming from the VirusScanWorker:
- Errno::ENOENT: No such file or directory
- StateMachines::InvalidTransition: Cannot transition state via :scanned_clean
from :unscanned (Reason(s): File can't be blank)
Assets should go through the following stages:
1. unscanned => saved to the file system and scanned by ClamAV in a background
job.
2. scanned => Saved to AWS.
3. uploaded => removed from the file system.
However, it seems like the file has already been removed during the virus
scanning stage.
This adds logging so that we can trace the history of assets which raise the
above errors to try to diagnose the issue.
jkempster34
changed the title
mike29736
approved these changes
Nov 22, 2023
| @@ -85,6 +85,11 @@ class Asset | |||
| scope :undeleted, -> { where(deleted_at: nil) } | |||
|
|
|||
| state_machine :state, initial: :unscanned do | |||
| around_transition do |asset, transition, block| | |||
| Rails.logger.info("#{asset.id} - Asset#state_machine - event: #{transition.event}") | |||
There was a problem hiding this comment.
I'm not familiar with this state machine, so I'll assume that all Assets have an #id for all transitions (i.e. there's no point in using safe navigation here)
There was a problem hiding this comment.
(And I see that Transition#event comes from https://github.com/state-machines/state_machines/blob/v0.6.0/lib/state_machines/transition.rb#L65, so that's nothing to worry about)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/9YZ5VItp
We have an ongoing issue where we are seeing the following errors related to missing files coming from the VirusScanWorker:
Assets should go through the following stages:
However, it seems like the file has already been removed during the virus scanning stage.
This adds logging so that we can trace the history of assets which raise the above errors to try to diagnose the issue.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.