Enable serving whitehall asset from media download endpoint #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behaviour separated whitehall assets from regular assets by implementing a boolean check (mainstream?) which was false for whitehall assets. We are changing the behaviour of assets in whitehall, so that all assets (unless already published) will use the non-legacy download endpoint.
lauraghiorghisor-tw
deleted the
serve-whitehall-asset-from-media-download-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behaviour separated whitehall assets from regular assets by implementing a boolean check (mainstream?) which was false for whitehall assets.
We are changing the behaviour of assets in whitehall, so that all assets (unless already published) will use the non-legacy download endpoint.
The underlying reason is that whitehall is moving away from using
legacy_url_pathfor identifying assets, therefore the media endpoints need to work for whitehall assets too.Trello card here