Rename DeleteAssetFileFromNfsWorker

`Sidekiq::Worker` has been deprecated in Sidekiq 7, so we need to
replace it with `Sidekiq::Job`, and then rename the workers to be jobs.

app/models/asset.rb

@@ -108,7 +108,7 @@ class Asset
 
     after_transition to: :uploaded do |asset, _|
       asset.save!
-      DeleteAssetFileFromNfsWorker.perform_in(5.minutes, asset.id.to_s)
+      DeleteAssetFileFromNfsJob.perform_in(5.minutes, asset.id.to_s)
     end
   end
 

app/workers/delete_asset_file_from_nfs_worker.rb → app/sidekiq/delete_asset_file_from_nfs_job.rb

@@ -1,12 +1,12 @@
-class DeleteAssetFileFromNfsWorker
-  include Sidekiq::Worker
+class DeleteAssetFileFromNfsJob
+  include Sidekiq::Job
   sidekiq_options queue: "low_priority"
 
   def perform(asset_id)
     asset = Asset.find(asset_id)
     if asset.uploaded?
       FileUtils.rm_rf(File.dirname(asset.file.path))
-      Rails.logger.info("#{asset.id} - DeleteAssetFileFromNfsWorker - File removed")
+      Rails.logger.info("#{asset.id} - DeleteAssetFileFromNfsJob - File removed")
     end
   end
 end

config/brakeman.ignore

@@ -13,7 +13,7 @@
       "render_path": null,
       "location": {
         "type": "method",
-        "class": "DeleteAssetFileFromNfsWorker",
+        "class": "DeleteAssetFileFromNfsJob",
         "method": "perform"
       },
       "user_input": "Asset.find(asset_id).file",

lib/tasks/govuk_assets.rake

@@ -5,7 +5,7 @@ namespace :govuk_assets do
   task delete_file_from_nfs_for_assets_uploaded_to_s3: :environment do
     processor = AssetProcessor.new(scope: Asset.where(state: "uploaded"))
     processor.process_all_assets_with do |asset_id|
-      DeleteAssetFileFromNfsWorker.perform_async(asset_id.to_s)
+      DeleteAssetFileFromNfsJob.perform_async(asset_id.to_s)
     end
   end
 

spec/models/asset_spec.rb

@@ -1153,7 +1153,7 @@
       end
 
       it "triggers the delete asset file worker" do
-        expect(DeleteAssetFileFromNfsWorker).to receive(:perform_in)
+        expect(DeleteAssetFileFromNfsJob).to receive(:perform_in)
         asset.upload_success!
       end
     end

spec/workers/delete_asset_file_from_nfs_worker_spec.rb → spec/sidekiq/delete_asset_file_from_nfs_job_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe DeleteAssetFileFromNfsWorker, type: :worker do
+RSpec.describe DeleteAssetFileFromNfsJob, type: :worker do
   subject(:worker) { described_class.new }
 
   let(:asset) { FactoryBot.create(:asset, state:) }