[main][feat] Upgrade executor #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr-alpaca
reviewed
Dec 6, 2023
| @@ -596,4 +618,9 @@ contract PCSV3Executor01 is Executor { | |||
| vaultOracle = PancakeV3VaultOracle(_vaultOracle); | |||
| emit LogSetVaultOracle(_vaultOracle); | |||
| } | |||
|
|
|||
| function setSkipExposureChecks(address _vaultToken, bool _skip) external onlyOwner { | |||
| skipExposureChecks[_vaultToken] = _skip; | |||
There was a problem hiding this comment.
might be a good ideal to check if the _vaultToken actually exist.
There was a problem hiding this comment.
Good to have but not necessary. If vaultToken doesn't exist, it would fail during manage anyway.
jr-alpaca
approved these changes
Dec 6, 2023
wow-alpaca
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why?
ChangeLogs:
Link to story (if available)