Added FakeFacade #199
Open
Added FakeFacade #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesvdvreken
requested changes
May 10, 2024
| public static function fake($jobsToFake = []) | ||
| { | ||
| static::swap($fake = new FakeFacade(static::getFacadeRoot())); | ||
| return $fake; |
There was a problem hiding this comment.
Suggested change
| return $fake; | |
| return $fake; |
| */ | ||
| protected $twilio; | ||
|
|
||
| protected $history; |
|
|
||
| protected $history; | ||
|
|
||
| protected $settings = [ |
| use Aloha\Twilio\TwilioInterface; | ||
| use Aloha\Twilio\Manager as Twilio; | ||
| use Illuminate\Support\Arr; | ||
| use PHPUnit\Framework\Assert; |
There was a problem hiding this comment.
This will make phpunit a hard requirement (as opposed to dev-requirement) for this package. Not a good idea. Can we turn it around? for example:
getMessageSent(): Message
getCallSent(): Call
and let the test-suite which is testing it do the assertions.
|
Is there going to be any traction on this PR? I would be willing to write and submit a new PR to achieve this functionality as it's extremely useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a fake facade so devs can write tests in their system and confirm that the messages are being triggered. It works by calling
Twilio::fake()at the head of the test. They can then useTwilio::assertMessageSentandTwilio::assertCallSent