Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill solid optimizations per-color #145

Closed
wants to merge 6 commits into from
Closed

Fill solid optimizations per-color #145

wants to merge 6 commits into from

Conversation

almindor
Copy link
Owner

@almindor almindor commented Nov 11, 2024

This adds optimized (per color type) fill_solid paths as part of improving on issue #142.

This improved fill_solid fullscreen render speed on a ST7789 using 80Mhz SPI interface with esp32-c6 board running at 160Mhz CPU speed from ~48ms to ~18ms.

NOTE: the buffer size is arbitrarily chosen, bigger ones can get even better results, but I wanted to avoid using too much memory. If batch support is disabled these paths are not used. I hope we can come up with a better story for buffers overall in the future (e.g. wrt. to display-interface as well as this driver).

@almindor almindor requested a review from rfuest November 11, 2024 20:25
@almindor
Copy link
Owner Author

I'm also considering refactoring this using https://crates.io/crates/disjoint_impls/0.8.0 which should allow removal of the extra Model method and just doing it directly in the graphics module.

@almindor
Copy link
Owner Author

Closing in favour of #146 , however if for some reason we don't want to use the specialization "hack" we can fall back to this.

@almindor almindor closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant