-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct pixel writes from u8 buffers #143
Conversation
I think this is a valid workaround until we have something better available in the future. We just need to make sure to document possible issues a user could run into:
|
Sounds good, I'll add the documentation points. Do you plan to add the |
I'm not sure when that will be added or how exactly it will be implemented. I would suggest to leave that part out and open an issue to remind us to update the comment after this has been added to e-g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more doc comment bike shedding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #142 this change will allow direct writes of
&[u8]
slice data via thedisplay-interface
without needing to do pixel format conversion in cases where the user knows it is safe to do so (e.g. prepared image data).The hope is that this can get paired up with a change in
embedded-graphics
that enables such operations on a higher level (e.g.draw_image
)