Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in page unmount #289

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: in page unmount #289

merged 1 commit into from
Nov 8, 2024

Conversation

joyet-simon
Copy link
Contributor

Reason for change

Linear task

Code changes

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon requested a review from a team as a code owner November 7, 2024 15:02
@github-actions github-actions bot added the type: bugfix Bug fix label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarcloud bot commented Nov 7, 2024

@FranceBe
Copy link
Contributor

FranceBe commented Nov 7, 2024

@alma/squad-devx is this normal ?
Capture d’écran 2024-11-07 à 16 25 29

Copy link

github-actions bot commented Nov 7, 2024

❌ E2E tests have failed.
➡️ You can find the results here.

@gdraynz
Copy link
Contributor

gdraynz commented Nov 7, 2024

@alma/squad-devx is this normal ? Capture d’écran 2024-11-07 à 16 25 29

It is fine, we only ever call this Dockerfile with the right argument.

@joyet-simon joyet-simon merged commit 42b6ca0 into develop Nov 8, 2024
6 of 7 checks passed
@joyet-simon joyet-simon deleted the fix/in-page-unmount branch November 8, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants