feat: add Parlia genesis config for BSC #740
Conversation
forcodedancing
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
|
given that the config props are identical to clique config, should we reuse the struct? |
You are right. The fields are the same. However, the meanings of the fields are different for clique and parlia. I am ok if you think reuse is better. thanks a lot. |
Ya, I understand that in Parlia the fields are used differently than in clique. But given that the names and comments are the same it seems safe to reuse. I don't have a strong opinion here, so I'm fine leaving it as 2 identical structs |
crates/genesis/src/lib.rs
Outdated
| @@ -541,6 +545,21 @@ pub struct CliqueConfig { | |||
| pub epoch: Option<u64>, | |||
| } | |||
|
|
|||
| /// Consensus configuration for Parlia. | |||
| /// Parlia is the consensus engine for BNB Smart Chain. | |||
| /// For the general introduction: https://docs.bnbchain.org/docs/learn/consensus/ | |||
There was a problem hiding this comment.
doc nit again:
for links you should follow recommendation here:
https://doc.rust-lang.org/rustdoc/lints.html?highlight=http%3A%2F%2F#bare_urls
There was a problem hiding this comment.
There was a problem hiding this comment.
fixed, thanks a lot
* feat: add Parlia genesis config for BSC * chore: update comments based on review suggestion * fix review comments
Motivation
BSC uses Parlia consensus engine. To support BSC genesis, Parlia config is added.
Solution
Update genesis config to support Parlia.