-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simple IPC
test
#65
Conversation
install_geth & | ||
g=$! | ||
wait $g $! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
install_geth & | |
g=$! | |
wait $g $! | |
install_geth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would really love not to install geth in our tests, is there an expedient way we can do this with a mock? 😮💨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prestwich seems like the ipc client doesn't read the stream at all and it times out? https://github.com/alloy-rs/alloy/actions/runs/7119215013/job/19383813553
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test passes now @prestwich — any chance we can merge like this and clean up geth later?
* feature: interprocess-based IPC * cleanup: tracing and flow * feat: log buffer contents * chore: do not run wasm check on alloy-transport-ipc * chore: add cc0-1.0 for to_method * fix: buffer properly * feature: some rexports and client impl * feature: mock ipc * docs: some of them * lint: clippy * nit: newline * feat: close file so other processes can access it * feat: simple `IPC` test (#65) * chore: add basic ipc test * install test binaries * feat: ipc connection on builder if ipc feat is enabled * chore: remove, better done separately * review comments * review comments * chore: remove unused crates for now * add to dev deps * chore: add instructions for repro on ipc test * chore: re-add normal test * clippy * chore: change test to use mock ipc * add mock * no sleep till brooklyn * chore: revert to geth impl for now --------- Co-authored-by: Enrique Ortiz <[email protected]>
Motivation
IPC didn't have any tests for making a request
Solution
Adds a simple sanity test using the geth binary (we can switch it out for a mock later)
PR Checklist