feat: simple IPC test
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested changes
Dec 6, 2023
Comment on lines
23
to
25
| install_geth & | ||
| g=$! | ||
| wait $g $! |
There was a problem hiding this comment.
Suggested change
| install_geth & | |
| g=$! | |
| wait $g $! | |
| install_geth |
There was a problem hiding this comment.
i would really love not to install geth in our tests, is there an expedient way we can do this with a mock? 😮💨
Evalir
commented
Dec 6, 2023
There was a problem hiding this comment.
@prestwich seems like the ipc client doesn't read the stream at all and it times out? https://github.com/alloy-rs/alloy/actions/runs/7119215013/job/19383813553
Evalir
commented
Dec 8, 2023
There was a problem hiding this comment.
test passes now @prestwich — any chance we can merge like this and clean up geth later?
Evalir
added a commit
that referenced
this pull request
Dec 8, 2023
* feature: interprocess-based IPC * cleanup: tracing and flow * feat: log buffer contents * chore: do not run wasm check on alloy-transport-ipc * chore: add cc0-1.0 for to_method * fix: buffer properly * feature: some rexports and client impl * feature: mock ipc * docs: some of them * lint: clippy * nit: newline * feat: close file so other processes can access it * feat: simple `IPC` test (#65) * chore: add basic ipc test * install test binaries * feat: ipc connection on builder if ipc feat is enabled * chore: remove, better done separately * review comments * review comments * chore: remove unused crates for now * add to dev deps * chore: add instructions for repro on ipc test * chore: re-add normal test * clippy * chore: change test to use mock ipc * add mock * no sleep till brooklyn * chore: revert to geth impl for now --------- Co-authored-by: Enrique Ortiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IPC didn't have any tests for making a request
Solution
Adds a simple sanity test using the geth binary (we can switch it out for a mock later)
PR Checklist