Correctly sign non legacy transaction without EIP155 #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mattsse @prestwich , see also foundry-rs/foundry#7804 (comment) |
prestwich
reviewed
May 1, 2024
This was referenced May 12, 2024
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
Evalir
as code owners
alisinabh
commented
May 13, 2024
mattsse
reviewed
May 13, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* Add tx_type method to transaction * Remove chain_id from sign_hash_async * refactor: remove txtype from interface --------- Co-authored-by: James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Correctly sign non-legacy transactions with y_parity value instead of EIP155 value.
Solution
Only use with_chain_id method if transaction type is legacy.
This PR is in a PoC state and opened for discussion.
PR Checklist