Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: interprocess-based IPC #59

Merged
merged 13 commits into from
Dec 8, 2023
Merged

feature: interprocess-based IPC #59

merged 13 commits into from
Dec 8, 2023

Conversation

prestwich
Copy link
Member

Adds interprocess-based IPC pubsub backend.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Dec 2, 2023
@prestwich prestwich self-assigned this Dec 2, 2023
Evalir
Evalir approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm—will add at least a basic test for this and see if we can get Ci on multiple OSs. I think we need to stop CI from running wasm support on this crate as well

Evalir and others added 10 commits December 6, 2023 14:31
@Evalir
chore: do not run wasm check on alloy-transport-ipc
0995739
@prestwich
chore: add cc0-1.0 for to_method
b92525f
@prestwich
fix: buffer properly
6fd3164
@prestwich
feature: some rexports and client impl
d18b084
@prestwich
feature: mock ipc
5fa6402
@prestwich
docs: some of them
adbb4bc
@prestwich
lint: clippy
c00aa0e
@prestwich
nit: newline
67ebd79
@Evalir
feat: close file so other processes can access it
dbc808f
@Evalir
feat: simple IPC test (#65)
6005c4c 
* chore: add basic ipc test

* install test binaries

* feat: ipc connection on builder if ipc feat is enabled

* chore: remove, better done separately

* review comments

* review comments

* chore: remove unused crates for now

* add to dev deps

* chore: add instructions for repro on ipc test

* chore: re-add normal test

* clippy

* chore: change test to use mock ipc

* add mock

* no sleep till brooklyn

* chore: revert to geth impl for now
@Evalir Evalir merged commit 35a042f into main Dec 8, 2023
17 checks passed
@Evalir Evalir mentioned this pull request Dec 8, 2023
Closed
3 tasks
@DaniPopes DaniPopes deleted the prestwich/interprocess branch January 15, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @Evalir