Skip to content

Commit

Permalink
use to_raw_value from serde_json (#64)
Browse files Browse the repository at this point in the history
  • Loading branch information
robinsdan authored Dec 6, 2023
1 parent e1e0da6 commit 4033f21
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
4 changes: 1 addition & 3 deletions crates/json-rpc/src/packet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ impl RequestPacket {
pub fn serialize(self) -> serde_json::Result<Box<RawValue>> {
match self {
RequestPacket::Single(single) => Ok(single.take_request()),
RequestPacket::Batch(batch) => {
serde_json::to_string(&batch).and_then(RawValue::from_string)
}
RequestPacket::Batch(batch) => serde_json::value::to_raw_value(&batch),
}
}

Expand Down
9 changes: 3 additions & 6 deletions crates/json-rpc/src/request.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,13 @@ where
///
/// If serialization of the params fails.
pub fn box_params(self) -> PartiallySerializedRequest {
Request {
meta: self.meta,
params: RawValue::from_string(serde_json::to_string(&self.params).unwrap()).unwrap(),
}
Request { meta: self.meta, params: serde_json::value::to_raw_value(&self.params).unwrap() }
}

/// Serialize the request, including the request parameters.
pub fn serialize(self) -> serde_json::Result<SerializedRequest> {
let request = serde_json::to_string(&self)?;
Ok(SerializedRequest { meta: self.meta, request: RawValue::from_string(request)? })
let request = serde_json::value::to_raw_value(&self)?;
Ok(SerializedRequest { meta: self.meta, request })
}
}

Expand Down
8 changes: 5 additions & 3 deletions crates/transport/src/utils.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
use serde::Serialize;
use serde_json::{self, value::RawValue};
use serde_json::{
self,
value::{to_raw_value, RawValue},
};
use std::future::Future;
use url::Url;

Expand All @@ -11,8 +14,7 @@ pub fn to_json_raw_value<S>(s: &S) -> TransportResult<Box<RawValue>>
where
S: Serialize,
{
RawValue::from_string(serde_json::to_string(s).map_err(TransportError::ser_err)?)
.map_err(TransportError::ser_err)
to_raw_value(s).map_err(TransportError::ser_err)
}

/// Guess whether the URL is local, based on the hostname.
Expand Down

0 comments on commit 4033f21

Please sign in to comment.