Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HDMA, MBC3 and improve the debugger #145

Merged
merged 11 commits into from
Nov 1, 2024
Merged

Fix HDMA, MBC3 and improve the debugger #145

merged 11 commits into from
Nov 1, 2024

Conversation

alloncm
Copy link
Owner

@alloncm alloncm commented Oct 30, 2024

  • HDMA bug fixes:
    1. The vram dma transfer cycles counter was global and would not reset until the current transfer will end so upon certain threshold it no longer made transfers until the game canceled it
    2. The verification check that we are on different LY was not correct and was biased from the last trasnfer since it was never cleared to an invalid value, now using an Option to indicate new transfer
    3. Halt HDMA HBlank transfer during CPU halt
  • Add more functionality to the debugger
    1. Handle banks properly, allowing proper debugging of multi banks roms
    2. Add SkipHalt command to continue until the CPU is unhalted
    3. Improved memory dumping
  • Update readme
  • Multiple bug fixes for MBC3 causing it to panic
  • Add integration test for HDMA HBlank mode

Closes #126
Closes #114

The mapping for the MBC was missing and there was an error in the RTC registers access (buffer overflow which panicked) that caused the program to crash.

Now it is still unplayable cause of artifacts later the game restarts and detect the emulator as DMG device
core/src/debugger/mod.rs Outdated Show resolved Hide resolved
core/src/mmu/gb_mmu.rs Outdated Show resolved Hide resolved
@alloncm alloncm changed the title Fix HDMA bug and improved the debugger along the way Fix HDMA, MBC3 and improve the debugger Nov 1, 2024
@alloncm alloncm merged commit c7376d2 into master Nov 1, 2024
1 check passed
@alloncm alloncm deleted the fix/crystal branch November 1, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pokemon Crystal is crashing on start Legend of zelda links awakening dx is not working properly in CGB mode
1 participant