Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-1161: Debugging Settings: support sending notification to multiple email accounts #1181

Conversation

renatonascalves
Copy link

@renatonascalves renatonascalves commented Oct 11, 2024

Summary

Fixes #1161

This PR addresses the need to support sending debugging notifications to multiple email accounts as outlined in the issue #1161. It introduces functionality allowing the addition of multiple email addresses in the Developer Tools settings.

Description

The Developer Tools currently only support sending debugging information to a single email address. This enhancement allows for multiple users, each with different email addresses, to receive debugging notifications.

Use Case

This change is crucial for teams where multiple individuals need access to debugging notifications to ensure smooth development and troubleshooting processes.

Changes Made

  • Modified the handling of the debugging notifications setting to support multiple email addresses.
  • Updated the UI in the Developer Tools section to allow for the entry of multiple email addresses.

Acceptance Criteria

  • Allow adding, and sending, debugging notifications to multiple email addresses.

Testing

  1. Navigate to the Developer Tools settings.
  2. Add multiple email addresses to the debugging notifications field.
  3. Trigger a debugging event.
  4. Verify that all specified email addresses receive the debugging notification.

Additional Notes

A apple_news_notification_headers hook exists for developers, but this update provides a more user-friendly approach for non-technical users as well.

@renatonascalves renatonascalves marked this pull request as ready for review October 11, 2024 20:35
Copy link

@manewc manewc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📬

@renatonascalves renatonascalves merged commit 9cd91db into develop Oct 14, 2024
11 checks passed
@renatonascalves renatonascalves deleted the feature/issue-1161/support-multiple-email-debug-notifications branch October 14, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugging Settings: support sending notification to multiple email accounts
2 participants