Correct nginx proxy Host header #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Host header should be the target host not the source host
|
Hi @chriswue, I just want to be absolutely sure, but it seems this change contradicts the example shown here: http://nginx.org/en/docs/http/ngx_http_proxy_module.html |
|
@jkhenning Not sure which example you refer to specifically but this corroborates what I'm talking about: |
|
Any updates on this pull request? We would need that change as well. Thank you! |
|
@chriswue , since your change basically changes it back to the default, wouldn't it be better just to remove this line? |
|
That should work as well (but i am not sure), yes 🤔 Edit: Somehow deleting all pods and volumes and installing version 7.8.2 fixed the issue for us - so right now no need to change something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Host header should be the target host not the source host. Fixes #209