Added support for non-finite float and double values #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Java `float` or `double` value contains a non-finite value (`Infinity`, `-Infinity`, `NaN`) it is serialized in JSON as a String instead of a number (e.g. `3.1416`), as JSON numbers do not support non-finite values. If we try to convert a JSON with such values to AVRO it will fail. We have added support in `JsonGenericRecordReader` to support parsing `float` and `double` numbers as strings so `"NaN"`, `"Infinite"` and `"-Infinite"` are now parseable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Java
floatordoublevalue contains a non-finite value (Infinity,-Infinity,NaN) it is serialized in JSON as a String instead of a number (e.g.3.1416), as JSON numbers do not support non-finite values.If we try to convert a JSON with such values to AVRO it will fail.
We have added support in
JsonGenericRecordReaderto support parsingfloatanddoublenumbers as strings so"NaN","Infinite"and"-Infinite"are now parseable.