Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with -parameters flag and upgrade GitHub Actions #1828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deejay1
Copy link
Contributor

@deejay1 deejay1 commented Mar 2, 2024

Compile hermes with -parameters flag, because newer Spring drops parameter resolution through bytecode scanning, see https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-6.x#parameter-name-retention

@szczygiel-m
Copy link
Contributor

Hey, looks like changing this flag causes test fouls due to spring and jackson
org.springframework.core.codec.DecodingException: JSON decoding error: Cannot construct instance of pl.allegro.tech.hermes.api.EndpointAddressResolverMetadata, problem: Cannot invoke "java.util.Map.entrySet()" because "map" is null
Could You please take a look at this? https://github.com/allegro/hermes/actions/runs/8187892486?pr=1828

@deejay1
Copy link
Contributor Author

deejay1 commented Apr 4, 2024

Hey, looks like changing this flag causes test fouls due to spring and jackson org.springframework.core.codec.DecodingException: JSON decoding error: Cannot construct instance of pl.allegro.tech.hermes.api.EndpointAddressResolverMetadata, problem: Cannot invoke "java.util.Map.entrySet()" because "map" is null Could You please take a look at this? https://github.com/allegro/hermes/actions/runs/8187892486?pr=1828

I'll take a look at it tomorrow if I manage to

Compile hermes with `-parameters` flag, because newer Spring drops parameter resolution through bytecode scanning, see https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-6.x#parameter-name-retention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants