Support elastic search7 travis fix - support platforms. #98

pablotdl · 2020-04-10T18:37:19Z

Added support for downloading the platform specific versions of elasticsearch listed at https://www.elastic.co/downloads/elasticsearch.

This should complement the work by @eynand and @bekihm. Let's see what travis says.

…earch. This includes choosing the right URL for elastic 7 and the ability to install from tar.gz (besides zip)

…ing tar.gz files

…not maintaining exec permissions

bekihm

I added just two remarks on the code.

bekihm · 2020-04-14T07:23:59Z

core/src/main/java/pl/allegro/tech/embeddedelasticsearch/ElasticRestClient.java

+                return false;
+            }
+            String esV = jsonNode.get("version").get("number").asText();
+            return Integer.parseInt(esV.substring(0,1)) >= 7; //if version is 7 and above


What happens with elasticsearch version above 9? Can we use split with '.' sign to use the structure of the version number?

bekihm · 2020-04-14T07:40:51Z

es73-test/src/test/groovy/pl/allegro/tech/embeddedelasticsearch/PluginsInstallationSpec.groovy

+
+    EmbeddedElastic.Builder baseEmbeddedElastic() {
+        return EmbeddedElastic.builder()
+                .withElasticVersion("6.3.0")


We use here an older elasticsearch version for the tests?

pablotdl · 2020-04-16T14:48:58Z

Applied both suggestions @bekihm , thanks!

bekihm

LGTM 👍

bekihm · 2020-04-20T14:09:33Z

Exception in thread "ElsInstanceCleaner" java.lang.RuntimeException: pl.allegro.tech.embeddedelasticsearch.EmbeddedElasticsearchStartupException: Could not delete data directory of embedded elasticsearch server. Possibly an instance is running.

@pablotdl Had travis temporarily problems to run the build?

pablotdl · 2020-04-20T21:53:24Z

Looks like a problem with an ES plugin

pablotdl · 2020-04-20T21:57:31Z

Indeed, the discovery-file plugin is removed in 7.3, let's see if another one makes the trick.

bekihm

Seems that the alternative plugin has done the job 👍

pablotdl · 2020-04-21T16:06:28Z

Yep, hope it gets merged now.

pablotdl · 2020-04-21T16:07:42Z

Yep, hope it gets merged now.

vojtapol · 2020-05-02T15:31:12Z

This PR is broken for 6.4.3, looks like the startup fails because of file system permissions:

2020-05-02 11:28:36 [     main] .e.ElasticSearchInstaller: Installing Elasticsearch into /var/folders/fv/t18bf1dx3pddjnxhrpcwt2yc0000gn/T/embedded-elasticsearch-temp-dir... 
2020-05-02 11:28:38 [     main] .e.ElasticSearchInstaller: Done 
2020-05-02 11:28:38 [     main]     p.a.t.e.ElasticServer: Waiting for ElasticSearch to start... 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: [2020-05-02T11:28:39,269][WARN ][o.e.b.ElasticsearchUncaughtExceptionHandler] [] uncaught exception in thread [main] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: org.elasticsearch.bootstrap.StartupException: org.elasticsearch.bootstrap.BootstrapException: java.io.IOException: Cannot run program "/var/folders/fv/t18bf1dx3pddjnxhrpcwt2yc0000gn/T/embedded-elasticsearch-temp-dir/elasticsearch-6.4.3/modules/x-pack-ml/platform/darwin-x86_64/bin/controller": error=13, Permission denied 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:140) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:127) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:124) ~[elasticsearch-cli-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.cli.Command.main(Command.java:90) ~[elasticsearch-cli-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:93) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:86) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: Caused by: org.elasticsearch.bootstrap.BootstrapException: java.io.IOException: Cannot run program "/var/folders/fv/t18bf1dx3pddjnxhrpcwt2yc0000gn/T/embedded-elasticsearch-temp-dir/elasticsearch-6.4.3/modules/x-pack-ml/platform/darwin-x86_64/bin/controller": error=13, Permission denied 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:168) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:326) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:136) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	... 6 more 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: Caused by: java.io.IOException: Cannot run program "/var/folders/fv/t18bf1dx3pddjnxhrpcwt2yc0000gn/T/embedded-elasticsearch-temp-dir/elasticsearch-6.4.3/modules/x-pack-ml/platform/darwin-x86_64/bin/controller": error=13, Permission denied 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048) ~[?:1.8.0_242] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Spawner.spawnNativeController(Spawner.java:118) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Spawner.spawnNativeControllers(Spawner.java:86) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:166) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:326) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:136) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	... 6 more 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: Caused by: java.io.IOException: error=13, Permission denied 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at java.lang.UNIXProcess.forkAndExec(Native Method) ~[?:1.8.0_242] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at java.lang.UNIXProcess.<init>(UNIXProcess.java:247) ~[?:1.8.0_242] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at java.lang.ProcessImpl.start(ProcessImpl.java:134) ~[?:1.8.0_242] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029) ~[?:1.8.0_242] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Spawner.spawnNativeController(Spawner.java:118) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Spawner.spawnNativeControllers(Spawner.java:86) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:166) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:326) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:136) ~[elasticsearch-6.4.3.jar:6.4.3] 
2020-05-02 11:28:39 [lsHandler]     p.a.t.e.ElasticServer: 	... 6 more

Drori, Eynan and others added 7 commits October 7, 2019 14:04

add support for es 7.x

8a73dc0

add es 7.3 unit tests

4df0850

Update README.md

b304743

Update README.md

5bd0d56

Update README.md

0f12d09

Change dist to trusty

a82f106

Added support for downloading platform specific versions of elastic s…

5794b0d

…earch. This includes choosing the right URL for elastic 7 and the ability to install from tar.gz (besides zip)

pablotdl mentioned this pull request Apr 10, 2020

add es 7.x support #94

Open

pablosaavedra-rappi added 4 commits April 10, 2020 16:16

Setting executable permission if nedded and fixed a bug when download…

f434fc2

…ing tar.gz files

Another attempt to fix tests

883a33c

Another file that needs to be executable

5fbf7dd

This is probably too hacky by now, but for some reason zip files are …

b42153a

…not maintaining exec permissions

bekihm reviewed Apr 14, 2020

View reviewed changes

Fixed code review comments

43b15ff

bekihm approved these changes Apr 18, 2020

View reviewed changes

Replaced deprecated plugin

bf62032

bekihm approved these changes Apr 21, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support elastic search7 travis fix - support platforms. #98

Support elastic search7 travis fix - support platforms. #98

pablotdl commented Apr 10, 2020

bekihm left a comment

bekihm Apr 14, 2020

bekihm Apr 14, 2020

pablotdl commented Apr 16, 2020

bekihm left a comment

bekihm commented Apr 20, 2020

pablotdl commented Apr 20, 2020

pablotdl commented Apr 20, 2020

bekihm left a comment

pablotdl commented Apr 21, 2020

pablotdl commented Apr 21, 2020

vojtapol commented May 2, 2020

Support elastic search7 travis fix - support platforms. #98

Are you sure you want to change the base?

Support elastic search7 travis fix - support platforms. #98

Conversation

pablotdl commented Apr 10, 2020

bekihm left a comment

Choose a reason for hiding this comment

bekihm Apr 14, 2020

Choose a reason for hiding this comment

bekihm Apr 14, 2020

Choose a reason for hiding this comment

pablotdl commented Apr 16, 2020

bekihm left a comment

Choose a reason for hiding this comment

bekihm commented Apr 20, 2020

pablotdl commented Apr 20, 2020

pablotdl commented Apr 20, 2020

bekihm left a comment

Choose a reason for hiding this comment

pablotdl commented Apr 21, 2020

pablotdl commented Apr 21, 2020

vojtapol commented May 2, 2020