Fixes issue #3 caused by deprecated NOAA service endpoint. Syntax fix…

…es (PSR formatting) and some namespace use cases cleaned up.
allebb · Nov 17, 2016 · 7b2a2f6 · 7b2a2f6
1 parent 2e0c341
commit 7b2a2f6
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 11 deletions.
diff --git a/examples/Examples.php b/examples/Examples.php
@@ -14,6 +14,6 @@
  * this can be achieved by 
  */
 $leib = new Metar('LEIB');
-$leib->setProvider('VATSIM');
+$leib->setProvider(Ballen\Metar\Providers\Vatsim::class);
 echo sprintf('The VATSIM METAR report for Ibiza airport (LEIB) is: %s', $leib);
 
diff --git a/lib/Helpers/MetarHTTPClient.php b/lib/Helpers/MetarHTTPClient.php
@@ -1,5 +1,4 @@
 <?php
-
 namespace Ballen\Metar\Helpers;
 
 use GuzzleHttp\Client as HttpClient;

diff --git a/lib/Metar.php b/lib/Metar.php
@@ -1,5 +1,4 @@
 <?php
-
 namespace Ballen\Metar;
 
 /**

diff --git a/lib/Providers/Ivao.php b/lib/Providers/Ivao.php
@@ -1,5 +1,4 @@
 <?php
-
 namespace Ballen\Metar\Providers;
 
 /**
@@ -14,7 +13,6 @@
  * @link http://www.bobbyallen.me
  *
  */
-use \Ballen\Metar\Providers\MetarProviderInterface;
 use \Ballen\Metar\Helpers\MetarHTTPClient;
 
 /**

diff --git a/lib/Providers/MetarProviderInterface.php b/lib/Providers/MetarProviderInterface.php
@@ -1,5 +1,4 @@
 <?php
-
 namespace Ballen\Metar\Providers;
 
 /**

diff --git a/lib/Providers/Noaa.php b/lib/Providers/Noaa.php
@@ -1,5 +1,4 @@
 <?php
-
 namespace Ballen\Metar\Providers;
 
 /**
@@ -14,7 +13,6 @@
  * @link http://www.bobbyallen.me
  *
  */
-use \Ballen\Metar\Providers\MetarProviderInterface;
 use \Ballen\Metar\Helpers\MetarHTTPClient;
 
 /**
@@ -24,7 +22,7 @@
 class Noaa extends MetarHTTPClient implements MetarProviderInterface
 {
 
-    private $serviceUrl = 'http://weather.noaa.gov/pub/data/observations/metar/stations/{{_ICAO_}}.TXT';
+    private $serviceUrl = 'http://tgftp.nws.noaa.gov/data/observations/metar/stations/{{_ICAO_}}.TXT';
     private $icao;
 
     public function __construct($icao)

diff --git a/lib/Providers/Vatsim.php b/lib/Providers/Vatsim.php
@@ -1,5 +1,4 @@
 <?php
-
 namespace Ballen\Metar\Providers;
 
 /**
@@ -14,7 +13,6 @@
  * @link http://www.bobbyallen.me
  *
  */
-use \Ballen\Metar\Providers\MetarProviderInterface;
 use \Ballen\Metar\Helpers\MetarHTTPClient;
 
 /**
-Original file line number
+Diff line change
@@ -1,5 +1,4 @@
     <?php
     namespace Ballen\Metar;
     /**
@@ Expand Down @@