-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename dotenv
to load
#94
Conversation
This commit renames the primary function that loads the dotenv file to `load`. `dotenv` is still around with a deprecation warning. The renaming is discussed in [Discussion #39](#39). This renaming follows the naming convention in Ruby and Go implementations, using [`Dotenv.load`](https://github.com/bkeepers/dotenv) and [`godotenv.Load`](https://github.com/joho/godotenv) respectively.
I opened this but I would wait for further discussion in #39 |
@allan2 |
I have been making a lot of comments in the recent days. If I'm doing too much, please let me know. I do not want to overstep my role as a user of this repo. |
It depends on the issue. The next release is a new API with lots of breaking changes.
Not at all. PRs and discussions are welcome :) Closing because this PR is no longer relevant |
@allan2 Do you have any specific issues or PRs you'd like completed first? I can't remember if I already commented this somewhere else, but I'm ready to help out where I can -- some direction would be nice. |
@aidenfarley I marked some issues with a good first issue label. Docs can always be improved as well. If you do see something you would like to take on, just comment on the issue to let others know. |
This PR renames the primary function that loads the dotenv file to
load
.dotenv
is still around with a deprecation warning.The renaming is discussed in #39.
This renaming follows the naming convention in Ruby and Go implementations, which use
Dotenv.load
andgodotenv.Load
respectively.