Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dotenv to load #94

Closed
wants to merge 4 commits into from
Closed

Rename dotenv to load #94

wants to merge 4 commits into from

Conversation

allan2
Copy link
Owner

@allan2 allan2 commented Mar 18, 2024

This PR renames the primary function that loads the dotenv file to load.
dotenv is still around with a deprecation warning.

The renaming is discussed in #39.

This renaming follows the naming convention in Ruby and Go implementations, which use Dotenv.load and godotenv.Load respectively.

allan2 added 4 commits March 18, 2024 16:16
This commit renames the primary function that loads the dotenv file to
`load`.
`dotenv` is still around with a deprecation warning.

The renaming is discussed in [Discussion #39](#39).

This renaming follows the naming convention in Ruby and Go implementations, using [`Dotenv.load`](https://github.com/bkeepers/dotenv) and [`godotenv.Load`](https://github.com/joho/godotenv) respectively.
Copy link

Code Coverage

@allan2
Copy link
Owner Author

allan2 commented Mar 18, 2024

I opened this but I would wait for further discussion in #39

@allan2 allan2 mentioned this pull request Apr 18, 2024
@aidenfarley
Copy link

@allan2
Are you wishing to follow a more reserved or a more aggressive approach when it comes to getting these PRs merged and issues solved? I'm guessing, based on current behavior, that you're following a more reserved approach.
It might be worth considering being more aggressive, and possibly considering the next release a breaking one. This would allow us to implement a huge amount of these features we're trying to get in and a give us a nice foundation to work on from here.
Maybe a discussion could be opened about this, but ultimately it is your decision as the maintainer of the repository.

@aidenfarley
Copy link

I have been making a lot of comments in the recent days. If I'm doing too much, please let me know. I do not want to overstep my role as a user of this repo.

@allan2
Copy link
Owner Author

allan2 commented Sep 4, 2024

@allan2 Are you wishing to follow a more reserved or a more aggressive approach when it comes to getting these PRs merged and issues solved?

It depends on the issue. The next release is a new API with lots of breaking changes.

I have been making a lot of comments in the recent days. If I'm doing too much, please let me know. I do not want to overstep my role as a user of this repo.

Not at all. PRs and discussions are welcome :)

Closing because this PR is no longer relevant

@allan2 allan2 closed this Sep 4, 2024
@aidenfarley
Copy link

@allan2 Do you have any specific issues or PRs you'd like completed first? I can't remember if I already commented this somewhere else, but I'm ready to help out where I can -- some direction would be nice.

@allan2
Copy link
Owner Author

allan2 commented Sep 4, 2024

@aidenfarley I marked some issues with a good first issue label. Docs can always be improved as well.

If you do see something you would like to take on, just comment on the issue to let others know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants