fixes potential recursive error wrapping within error_handler, especi…

…ally in combination with echoHTTPErrors
allaboutapps · Sep 13, 2022 · 4cf20ba · 4cf20ba
1 parent 6eddec0
commit 4cf20ba
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/internal/api/router/error_handler.go b/internal/api/router/error_handler.go
@@ -43,7 +43,8 @@ func HTTPErrorHandlerWithConfig(config HTTPErrorHandlerConfig) echo.HTTPErrorHan
 
 			if code == http.StatusInternalServerError && config.HideInternalServerErrorDetails {
 				if httpError.Internal == nil {
-					httpError.Internal = fmt.Errorf("Internal Error: %w", httpError)
+					//nolint:errorlint
+					httpError.Internal = fmt.Errorf("Internal Error: %s", httpError)
 				}
 
 				httpError.Title = swag.String(http.StatusText(http.StatusInternalServerError))
@@ -54,7 +55,8 @@ func HTTPErrorHandlerWithConfig(config HTTPErrorHandlerConfig) echo.HTTPErrorHan
 
 			if code == http.StatusInternalServerError && config.HideInternalServerErrorDetails {
 				if httpValidationError.Internal == nil {
-					httpValidationError.Internal = fmt.Errorf("Internal Error: %w", httpValidationError)
+					//nolint:errorlint
+					httpValidationError.Internal = fmt.Errorf("Internal Error: %s", httpValidationError)
 				}
 
 				httpValidationError.Title = swag.String(http.StatusText(http.StatusInternalServerError))
@@ -64,7 +66,8 @@ func HTTPErrorHandlerWithConfig(config HTTPErrorHandlerConfig) echo.HTTPErrorHan
 
 			if code == http.StatusInternalServerError && config.HideInternalServerErrorDetails {
 				if echoHTTPError.Internal == nil {
-					echoHTTPError.Internal = fmt.Errorf("Internal Error: %w", echoHTTPError)
+					//nolint:errorlint
+					echoHTTPError.Internal = fmt.Errorf("Internal Error: %s", echoHTTPError)
 				}
 
 				he = &httperrors.HTTPError{