-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -j $JOBS to the CMake invocations missing it #5698
base: master
Are you sure you want to change the base?
Conversation
Also addressing some linting changes
Maybe we could link this to some useful update, like bumping fmt or a newer version of ninja? |
Good idea, I'll try to bump as many as possible
fmt error:
|
faircmakemodules.sh
Outdated
|
||
# Modulefile | ||
mkdir -p etc/modulefiles | ||
cat > etc/modulefiles/$PKGNAME <<EoF | ||
cat > etc/modulefiles/"$PKGNAME" <<EoF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this completely and simply use alibuild-generate-module (see other places)
@singiamtel can you retrigger the tests here to see if this is a transient problem? thanks. |
The failing tester no longer exists, it wasn't working properly (O2-5624). I think this should be okay to merge |
Also addressing some linting changes
This will trigger a big rebuild, we should run the Cache Jenkins job on merge