Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on implicit no remote store #893

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Warn on implicit no remote store #893

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a0f5e2
Warn on implicit no remote store
singiamtel Dec 13, 2024
35b0065
Improve message
singiamtel Dec 13, 2024
6dcf922
Fix tests
singiamtel Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions alibuild_helpers/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from alibuild_helpers.sync import remote_from_url
from alibuild_helpers.workarea import logged_scm, updateReferenceRepoSpec, checkout_sources
from alibuild_helpers.log import ProgressPrint, log_current_package
from alibuild_helpers.args import S3_SUPPORTED_ARCHS
from glob import glob
from textwrap import dedent
from collections import OrderedDict
Expand Down Expand Up @@ -451,6 +452,11 @@
'Maybe you need to "cd" to the right directory or '
'you forgot to run "aliBuild init"?' % args.configDir)

if (not args.no_remote_store and

Check warning on line 455 in alibuild_helpers/build.py

View check run for this annotation

Codecov / codecov/patch

alibuild_helpers/build.py#L455 

Added line #L455 was not covered by tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is fine for me. What happens on platforms where we prefer the system tools, like on macOS?

Could you add a test which exercises this part of the code?

not args.remoteStore and
args.architecture not in S3_SUPPORTED_ARCHS):
warning(f"Not using remote store cache because architecture {args.architecture} doesn't have a nightly build")

Check warning on line 458 in alibuild_helpers/build.py

View check run for this annotation

Codecov / codecov/patch

alibuild_helpers/build.py#L458 

Added line #L458 was not covered by tests

_, value = git(("symbolic-ref", "-q", "HEAD"), directory=args.configDir, check=False)
branch_basename = re.sub("refs/heads/", "", value)
branch_stream = re.sub("-patches$", "", branch_basename)
Expand Down
Loading