Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cs8 builders #1424

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Remove cs8 builders #1424

merged 3 commits into from
Nov 27, 2024

Conversation

singiamtel
Copy link
Collaborator

Not used anymore

As discussed over coffee break with @ktf @davidrohr

They have to be removed as required checks before merging

@singiamtel singiamtel requested a review from ktf as a code owner November 19, 2024 09:24
@ktf
Copy link
Member

ktf commented Nov 19, 2024

@Barthelemy should comment about QualityControl on CS8.

@singiamtel singiamtel force-pushed the cs8_non_dataflow_gone branch from 684ad55 to 730ddf5 Compare November 19, 2024 10:18
@Barthelemy
Copy link
Contributor

Hi,

Could you give me a bit of context ?

Thankyou

@singiamtel
Copy link
Collaborator Author

Hi @Barthelemy,

we're deprecating the cs8 builders as we need the computing to test the FullCI workflow in Alma 9. cs8 is EOL, and our production workload is not running in cs8 in any case (as far as I know). QualityControl is already being tested in Alma 9 so we believe it should be fine to remove this tester too

What's your opinion on this? Is it okay to go ahead and remove it? (To clarify, we only want to delete build/QualityControl/o2-cs8, not build/QualityControl/o2-dataflow-cs8)

Cheers,
Sergio

@Barthelemy
Copy link
Contributor

The whole FLP farm is on CS8 and we are not sure we are going to move to alma 9 because there is a severe issue with PDA and we depend on other people to fix it.

In QualityControl we use o2-dataflow-cs8 and o2-cs8.

I would not remove them until we know that we are moving to alma 9 or rhel 9 in the FLP farm. Otherwise we are not testing on the systems we are running onto.

@ktf
Copy link
Member

ktf commented Nov 22, 2024

Ok, fair enough. @singiamtel let's keep anything which includes QC / dataflow to cs8, then.

@davidrohr
Copy link
Contributor

davidrohr commented Nov 22, 2024 via email

@Barthelemy
Copy link
Contributor

@davidrohr good point. Actually we run on both FLPs and EPNs and thus it must be tested on both CS8 and Alma 9. I propose to keep o2-dataflow-cs8 on CS8 and have o2-cs8 on Alma.

@davidrohr
Copy link
Contributor

davidrohr commented Nov 22, 2024 via email

@Barthelemy
Copy link
Contributor

Barthelemy commented Nov 22, 2024

ok, so you are saying that QualityControl/O2fst/o2 running on Alma 9 + build/QualityControl/o2-dataflow-cs8 on CS8 is enough ?
(+mac but that's different)

@davidrohr
Copy link
Contributor

davidrohr commented Nov 22, 2024 via email

@Barthelemy
Copy link
Contributor

ok, then it sounds good. @singiamtel could you update this pr accordingingly ?
Thank you

@singiamtel
Copy link
Collaborator Author

singiamtel commented Nov 22, 2024

Ciao Barth,

Just to confirm, this should be the new status of the testers?

(Updated to reflect @davidrohr's comments)

  • AliceO2Group/AliceO2
    • build_O2_o2-cs8 -> Removed
    • build_O2_o2-dataflow-cs8
  • alisw/alidist
    • build_O2_alidist-cs8 -> Removed
    • build_O2_alidist-dataflow-cs8
  • AliceO2Group/QualityControl
    • build_QualityControl_o2-cs8 -> Removed
    • build_QualityControl_o2-dataflow-cs8
    • build_QualityControl_O2fst_o2 -> Migrated from slc7 to slc9-gpu-builder

And all the other cs8 checks stay untouched

  • AliceO2Group/Configuration
    • build_Configuration_o2-dataflow
  • AliceO2Group/InfoLogger
    • build_InfoLogger_o2-dataflow
  • AliceO2Group/Monitoring
    • build_Monitoring_o2-dataflow
  • AliceO2Group/ReadoutCard
    • build_ReadoutCard_o2-dataflow

@davidrohr
Copy link
Contributor

  • build/QualityControl/O2fst/o2 -> Migrated from slc7 to slc9

Isn't the current fst build on the slc8-gpu-builder container?

@singiamtel
Copy link
Collaborator Author

@davidrohr
Copy link
Contributor

Indeed, but that is just wrong. The FST test for the EPNs should use the GPU builder container as for O2 and for alidist.
Currently EPNs are on ALMA8, and we plan to move to ALMA9.

@singiamtel
Copy link
Collaborator Author

Indeed, but that is just wrong. The FST test for the EPNs should use the GPU builder container as for O2 and for alidist. Currently EPNs are on ALMA8, and we plan to move to ALMA9.

So it should've been using slc8-gpu-builder and we should migrate it now to use slc9-gpu-builder?

@davidrohr
Copy link
Contributor

Right now, the EPNs are on ALMA8, so all FullCI / FST builders should run with the slc8-gpu-builder.
So we should switch the qualitycontrol/fst from slc7 to slc8-gpu-builder.

And we remove all the -cs8 builders (not the -cs8-dataflow) to get some free resources.

In the next step, for preparing the EPNs for ALMA9, we have to duplicate all FullCI/FST builders in AliceO2 / QC / alidist from slc8-gpu-builder to slc9-gpu-builder.
And then, once EPNs are migrated, we will remove all old builders using slc8-gpu-builder container.

@singiamtel
Copy link
Collaborator Author

singiamtel commented Nov 25, 2024

@Barthelemy Can these two checks also be migrated to cs8?

  • build_O2_Common
  • build_QualityControl_o2

(Both currently running under slc7)

@Barthelemy
Copy link
Contributor

ok for me with the following

  1. build_O2_Common -> cs8
  2. build_QualityControl_o2 -> cs8
  3. build_QualityControl_o2-dataflow-cs8 -> no change
  4. build_QualityControl_O2fst_o2 -> cs8
  5. build_QualityControl_o2-cs8 -> Remove

Thank you Sergio

@singiamtel
Copy link
Collaborator Author

@ktf I think this is ready for merging then, could you take a look? It should be merged in parallel with the nomad config changes, I'll re-deploy the builders after

@ktf
Copy link
Member

ktf commented Nov 26, 2024

Looks good. Please go ahead and merge both PRs.

@ktf ktf merged commit 4708c58 into alisw:master Nov 27, 2024
2 checks passed
@singiamtel singiamtel deleted the cs8_non_dataflow_gone branch November 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants