-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cs8 builders #1424
Remove cs8 builders #1424
Conversation
@Barthelemy should comment about QualityControl on CS8. |
684ad55
to
730ddf5
Compare
Hi, Could you give me a bit of context ? Thankyou |
Hi @Barthelemy, we're deprecating the cs8 builders as we need the computing to test the FullCI workflow in Alma 9. cs8 is EOL, and our production workload is not running in cs8 in any case (as far as I know). QualityControl is already being tested in Alma 9 so we believe it should be fine to remove this tester too What's your opinion on this? Is it okay to go ahead and remove it? (To clarify, we only want to delete Cheers, |
The whole FLP farm is on CS8 and we are not sure we are going to move to alma 9 because there is a severe issue with PDA and we depend on other people to fix it. In QualityControl we use I would not remove them until we know that we are moving to alma 9 or rhel 9 in the FLP farm. Otherwise we are not testing on the systems we are running onto. |
Ok, fair enough. @singiamtel let's keep anything which includes QC / dataflow to cs8, then. |
Hi Barth, just for my understanding: I thought FLPs use the dataflow defaults. How are you using both o2 and o2-dataflow defaults for QC then?
Kind Regards
David Rohr
Sent from my mobile. (Excuse the typos!)
…On 22 November 2024 09:05:41 CET, "Barthélémy von Haller" ***@***.***> wrote:
The whole FLP farm is on CS8 and we are not sure we are going to move to alma 9 because there is a severe issue with PDA and we depend on other people to fix it.
In QualityControl we use `o2-dataflow-cs8` and `o2-cs8`.
I would not remove them until we know that we are moving to alma 9 or rhel 9 in the FLP farm. Otherwise we are not testing on the systems we are running onto.
--
Reply to this email directly or view it on GitHub:
#1424 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
@davidrohr good point. Actually we run on both FLPs and EPNs and thus it must be tested on both CS8 and Alma 9. I propose to keep o2-dataflow-cs8 on CS8 and have o2-cs8 on Alma. |
EPNs run a different build that is tested in the FullCI already.
Kind Regards
David Rohr
Sent from my mobile. (Excuse the typos!)
…On 22 November 2024 09:25:46 CET, "Barthélémy von Haller" ***@***.***> wrote:
@davidrohr good point. Actually we run on both FLPs and EPNs and thus it must be tested on both CS8 and Alma 9. I propose to keep o2-dataflow-cs8 on CS8 and have o2-cs8 on Alma.
--
Reply to this email directly or view it on GitHub:
#1424 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
ok, so you are saying that |
Yes, except that currently fst is still on alma8 and we will move to alma9 when epns move to alma9.
Kind Regards
David Rohr
Sent from my mobile. (Excuse the typos!)
…On 22 November 2024 09:30:45 CET, "Barthélémy von Haller" ***@***.***> wrote:
ok, so you are saying that `QualityControl/O2fst/o2` running on Alma 9 + `build/QualityControl/o2-dataflow-cs8 ` on CS8 is enough ?
(+mac but that's different)
--
Reply to this email directly or view it on GitHub:
#1424 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
ok, then it sounds good. @singiamtel could you update this pr accordingingly ? |
Ciao Barth, Just to confirm, this should be the new status of the testers? (Updated to reflect @davidrohr's comments)
And all the other cs8 checks stay untouched
|
Isn't the current fst build on the slc8-gpu-builder container? |
Indeed, but that is just wrong. The FST test for the EPNs should use the GPU builder container as for O2 and for alidist. |
So it should've been using slc8-gpu-builder and we should migrate it now to use slc9-gpu-builder? |
Right now, the EPNs are on ALMA8, so all FullCI / FST builders should run with the slc8-gpu-builder. And we remove all the -cs8 builders (not the -cs8-dataflow) to get some free resources. In the next step, for preparing the EPNs for ALMA9, we have to duplicate all FullCI/FST builders in AliceO2 / QC / alidist from slc8-gpu-builder to slc9-gpu-builder. |
@Barthelemy Can these two checks also be migrated to cs8?
(Both currently running under slc7) |
ok for me with the following
Thank you Sergio |
@ktf I think this is ready for merging then, could you take a look? It should be merged in parallel with the nomad config changes, I'll re-deploy the builders after |
Looks good. Please go ahead and merge both PRs. |
Not used anymore
As discussed over coffee break with @ktf @davidrohr
They have to be removed as required checks before merging