Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use branches (not SHAs) for formatting workflow #1280

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

TimoWilken
Copy link
Contributor

The SHAs that GitHub provides might be outdated, so we'd see lots more changed files than are actually in the given PR.

By using the branch name (and fetching branches after cloning, for good measure), we should always get the latest commits in question.

The SHAs that GitHub provides might be outdated, so we'd see lots more changed
files than are actually in the given PR.

By using the branch name (and fetching branches after cloning, for good
measure), we should always get the latest commits in question.
@TimoWilken TimoWilken requested a review from ktf as a code owner January 19, 2024 13:15
@TimoWilken TimoWilken merged commit 264e7c1 into alisw:master Jan 19, 2024
1 check passed
@TimoWilken TimoWilken deleted the fix-formatting-old-shas branch January 19, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant