Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting workflow improvements #1279

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

TimoWilken
Copy link
Contributor

@TimoWilken TimoWilken commented Jan 16, 2024

Both changes are pretty simple, so it seemed easier to bundle them into one PR.

See commits below for more details.

  1. 'Annotate error messages with file/line number in output log': as requested by @davidrohr.
  2. 'Remove unneeded "check passed" summaries': These only take up space on the summary page, and since GitHub only renders the first few step summaries, a few "check passed" summaries can mask errors further down the page.

Hide whitespace/indentation changes in the diff to make it even simpler.

GitHub doesn't do this automatically, for whatever reason.
These only take up space on the summary page, and since GitHub only renders
the first few step summaries, a few "<check> passed" summaries can mask errors
further down the page.
@TimoWilken TimoWilken requested a review from ktf as a code owner January 16, 2024 13:23
@ktf ktf merged commit 4dbbe62 into alisw:master Jan 16, 2024
2 checks passed
@TimoWilken TimoWilken deleted the formatting-workflow-improvements branch January 16, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants