Track commit push time #1233
Track commit push time #1233
Conversation
TimoWilken
force-pushed
the
track-pr-delay
branch
from
8bfeb22 to
375d7ca
Compare
TimoWilken
force-pushed
the
track-pr-delay
branch
2 times, most recently
from
0b4b1df to
bc5acf2
Compare
|
Tested and working in CI now @ktf; ready for review! |
|
Can you squash the commits and provide a summary? You mention some issue with Drafts PRs but then it's not clear from the history if this has been solved. |
This should give a good approximation of the time a commit was submitted for testing. It still breaks down for draft PRs that are marked non-draft after a while, but PRs that are opened as non-draft from old commits are handled correctly. The alternative would be to use the PR's updatedAt property, but then any comments posted in the PR would reset the waiting timer.
TimoWilken
force-pushed
the
track-pr-delay
branch
from
b558a01 to
0de0595
Compare
|
Squashed. Draft PRs are unfortunately still a problem, but I can't see a way around it using the GraphQL API. The alternative to the current approach would be to use the PR's |
|
As long as the only side effect is that draft PRs will not have the correct number associated, I think we do not care. |
|
Yes, the problem only occurs for PRs that were draft at the time of their latest push (or creation) and are then made non-draft later. In that case, I'll merge this PR, since I've tested the changes already. |
This should give a good approximation of the time a commit was submitted for testing. It still breaks down for draft PRs that are marked non-draft after a while.
Draft because it needs testing.