Skip to content

Commit

Permalink
Improve installation order (#1389)
Browse files Browse the repository at this point in the history
In case we need to split the packages to be installed, always keep
the toplevel packages last, so that we do not risk
  • Loading branch information
ktf authored Aug 20, 2024
1 parent 288e793 commit 6e213cd
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions publish/aliPublishS3
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,20 @@ def sync(pub, architectures, s3Client, bucket, baseUrl, basePrefix, rules,
error("Too many packages to publish (%d); limiting to %d to avoid "
"running out of temporary disk space",
len(pubPackages), publishLimit)
# We make sure that if we split, O2Physics, O2 and other toplevel packages
# get installed last.
def custom_sort_key(s):
for l in ["Suite", "QualityControl", "AliGenerator"]:
if l in s:
return (3, s)
for l in ["O2Physics", "AliPhysics"]:
if l in s:
return (2, s)
for l in ["O2", "AliRoot"]:
if l in s:
return (1, s)
return (0, s)
pubPackages = sorted(pubPackages, key=custom_sort_key)
pubPackages = pubPackages[:publishLimit]

# Packages installation
Expand Down

0 comments on commit 6e213cd

Please sign in to comment.