fix(Input): don't stop propagation of keyboard events

alirezamirian · Dec 9, 2024 · b5e8308 · b5e8308
1 parent 4a9be6b
commit b5e8308
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/packages/jui/src/InputField/Input.cy.tsx b/packages/jui/src/InputField/Input.cy.tsx
@@ -46,10 +46,28 @@ describe("Input", () => {
       cy.mount(<Input ref={ref} />);
       cy.wrap(ref).its("current").should("be.instanceOf", HTMLDivElement);
     });
+
     it("forwards ref to the input element", () => {
       const ref = React.createRef<HTMLInputElement>();
       cy.mount(<Input inputRef={ref} />);
       cy.wrap(ref).its("current").should("be.instanceOf", HTMLInputElement);
     });
+
+    it("doesn't stop propagation of keyboard events", () => {
+      const onKeyDown = cy.stub();
+      const onKeyUp = cy.stub();
+      const onParentKeyDown = cy.stub();
+      const onParentKeyUp = cy.stub();
+      cy.mount(
+        <div onKeyDown={onParentKeyDown} onKeyUp={onParentKeyUp}>
+          <Input onKeyDown={onKeyDown} onKeyUp={onKeyUp} />
+        </div>
+      );
+      cy.get("input").focus().type("a");
+      cy.wrap(onKeyDown).should("be.calledOnce");
+      cy.wrap(onKeyUp).should("be.calledOnce");
+      cy.wrap(onParentKeyDown).should("be.calledOnce");
+      cy.wrap(onParentKeyUp).should("be.calledOnce");
+    });
   });
 });
diff --git a/packages/jui/src/InputField/Input.tsx b/packages/jui/src/InputField/Input.tsx
@@ -146,8 +146,6 @@ export const Input = React.forwardRef(function Input(
     style,
     className,
     inputRef: inputRefProp,
-    onKeyDown,
-    onKeyUp,
     onFocus,
     onBlur,
     autoFocus,
@@ -164,8 +162,6 @@ export const Input = React.forwardRef(function Input(
       autoFocus,
       onFocus,
       onBlur,
-      onKeyDown,
-      onKeyUp,
     } as FocusableOptions,
     inputRef
   );