Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MI-72: Update template to match with recent changes #1090

Merged
merged 30 commits into from
Nov 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ecab21f
MI-72: Update Typescript configurations
kai-nguyen-aligent Oct 25, 2024
0689cff
MI-72: Upgrade template & upgrade dev dependencies
kai-nguyen-aligent Oct 25, 2024
639687a
MI-72: Update nx.json to match with new vitest config
kai-nguyen-aligent Oct 25, 2024
047b2ae
MI-72: Few small clean-up
kai-nguyen-aligent Oct 25, 2024
b524315
MI-72: Fixed incorrect schema path
kai-nguyen-aligent Oct 25, 2024
98664c1
MI-72: Added back baseUrl as it is needed for `@nx/js`
kai-nguyen-aligent Oct 25, 2024
0b98661
MI-72: Prevent vitest to be bumped to 1.6.0
kai-nguyen-aligent Oct 25, 2024
9e6fcdc
MI-72: Adopt new TS coding standard editorconfig
kai-nguyen-aligent Oct 25, 2024
fc89ec6
MI-72: Remove redundant test executor
kai-nguyen-aligent Oct 28, 2024
f1feae6
MI-72: update clean package.json
kai-nguyen-aligent Oct 28, 2024
1e8ee7f
MI-72: Upgrade to nx 20 to fix npm ci issue
kai-nguyen-aligent Oct 29, 2024
90bd2a8
M-72: Use aligent standard prettier config
kai-nguyen-aligent Oct 29, 2024
dda24df
MI-72: Use Aligent standard tsconfig
kai-nguyen-aligent Oct 29, 2024
ec671ee
MI-72: Small update to serverless-plugin
kai-nguyen-aligent Oct 29, 2024
df009d4
MI-72: Update with Aligent standard eslint
kai-nguyen-aligent Oct 30, 2024
5acfea1
MI-72: Removed redundant files
kai-nguyen-aligent Oct 30, 2024
4e38d70
MI-72: Remove redundant dev dependencies
kai-nguyen-aligent Oct 30, 2024
9b6f904
MI-72: Bump Nx to v20.0.6
kai-nguyen-aligent Oct 30, 2024
1f49988
MI-72: Update template to use new eslint
kai-nguyen-aligent Oct 30, 2024
b9b940d
MI-72: Include workspace package.json to no-extraneous-dependencies
kai-nguyen-aligent Oct 30, 2024
28bc466
MI-72: Added Aligent private NPM registry token
kai-nguyen-aligent Oct 30, 2024
ff46b8c
MI-72: Update npm registry domain to the correct one
kai-nguyen-aligent Oct 30, 2024
3786d9e
MI-72: Remove unused file
kai-nguyen-aligent Oct 31, 2024
1db4f3d
MI-72: Removed private npm from workflow
kai-nguyen-aligent Nov 6, 2024
445db00
MI-72: Use publish registry for npm packages
kai-nguyen-aligent Nov 6, 2024
f3e476b
MI-72: Use @nx/vite & @nx/eslint plugins
kai-nguyen-aligent Nov 11, 2024
0cc0277
MI-72: Update to use new ts standard
kai-nguyen-aligent Nov 19, 2024
82f2e89
MI-72: Update template's eslint
kai-nguyen-aligent Nov 19, 2024
2a36eaa
MI-72: Fixed package-lock.json
kai-nguyen-aligent Nov 19, 2024
60875e3
MI-72: Update node version to latest supported by Lambda
kai-nguyen-aligent Nov 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MI-72: Upgrade to nx 20 to fix npm ci issue
kai-nguyen-aligent committed Oct 29, 2024
commit 1e8ee7fbbd434284957e823803f1f0da6814915d
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
@@ -116,14 +116,14 @@ The NPM packages in `devDependencies` in this repository has a complicated relat
"@typescript-eslint/parser": "^6.13.2",
```

- `@nx/esbuild` lists `esbuild` as peerDependency. Double check the required version of `esbuild` in `package.json` of this [package](https://www.npmjs.com/package/@nx/esbuild/v/17.3.0?activeTab=code) before upgrading.
- `@nx/esbuild` lists `esbuild` as peerDependency. Double check the required version of `esbuild` in `package.json` of this [package](https://www.npmjs.com/package/@nx/esbuild?activeTab=code) before upgrading.
- `eslint` is a peerDependency of the following packages. Double check the required version of `eslint` in `package.json` of these packages before upgrading.
- [@nx/eslint](https://www.npmjs.com/package/@nx/eslint/v/17.3.0?activeTab=code)
- [@typescript-eslint/eslint-plugin](https://www.npmjs.com/package/@typescript-eslint/eslint-plugin/v/6.13.2?activeTab=code)
- [@typescript-eslint/parser](https://www.npmjs.com/package/@typescript-eslint/parser/v/6.13.2?activeTab=code)
- [eslint-config-prettier](https://www.npmjs.com/package/eslint-config-prettier/v/9.1.0?activeTab=code)
- [eslint-plugin-import](https://www.npmjs.com/package/eslint-plugin-import/v/2.29.1?activeTab=code)
- `@nx/vite` lists `vite` and `vitest` as peerDependencies. Double check the required version of `vite` and `vitest` in `package.json` of this [package](https://www.npmjs.com/package/@nx/vite/v/17.3.0?activeTab=code) before upgrading.
- [@nx/eslint](https://www.npmjs.com/package/@nx/eslint?activeTab=code)
- [@typescript-eslint/eslint-plugin](https://www.npmjs.com/package/@typescript-eslint/eslint-plugin?activeTab=code)
- [@typescript-eslint/parser](https://www.npmjs.com/package/@typescript-eslint/parser?activeTab=code)
- [eslint-config-prettier](https://www.npmjs.com/package/eslint-config-prettier?activeTab=code)
- [eslint-plugin-import](https://www.npmjs.com/package/eslint-plugin-import?activeTab=code)
- `@nx/vite` lists `vite` and `vitest` as peerDependencies. Double check the required version of `vite` and `vitest` in `package.json` of this [package](https://www.npmjs.com/package/@nx/vite?activeTab=code) before upgrading.
- `vitest`, `@vitest/coverage-v8` and `@vitest/ui` should be at the same version.

## Under development
4 changes: 1 addition & 3 deletions nx.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
{
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"affected": {
"defaultBase": "origin/staging"
},
"defaultBase": "origin/staging",
"generators": {
"@aligent/serverless-plugin:service": {
"brand": "brand-name"
Loading