BEG-154: Correct uses from helper config function #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlaishley
requested review from
aligent-lturner and
mausham-shrestha-aligent
|
No rush on this one from my end, it turns out KMD preferenced these classes so I've applied these changes to our project directly. |
mausham-shrestha-aligent
approved these changes
Apr 3, 2024
aligent-lturner
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems I was a little too copy+paste happy when implementing these changes, and no one picked it up. I remember having them correct at one stage but it seems I might have stashed those at some point.
Only two classes need amending, the third is correct.