BEG-151: Add custom StagedProductAttributeSubscription for catalog_product_link table #17 #18
Conversation
…oduct_link table #17
There was a problem hiding this comment.
Can we make the name of this class more specific? It's really only for the catalog_product_link table, so it should reflect that.
etc/di.xml
Outdated
| @@ -28,4 +28,16 @@ | |||
| </argument> | |||
| </arguments> | |||
| </type> | |||
| <virtualType name="customStagedProductAttributeSubscription" type="Aligent\PrerenderIo\Model\Mview\View\Attribute\Subscription"> | |||
There was a problem hiding this comment.
This virtual type name should be more specific, also.
Additionally, you don't actually need a virtual type here - you can just define the entityInterface argument for the type itself (and then use the type as an argument for SubscriptionFactory
etc/di.xml
Outdated
| <argument name="entityInterface" xsi:type="string">Magento\Catalog\Api\Data\ProductInterface</argument> | ||
| </arguments> | ||
| </virtualType> | ||
| <type name="Magento\CatalogStaging\Model\Mview\View\SubscriptionFactory"> |
There was a problem hiding this comment.
Is it possible to use the subscription_model attribute within mview.xml instead of relying on the Magento_CatalogStaging module? Don't want to include an enterprise-only dependency if we can avoid it.
etc/module.xml
Outdated
| <module name="Aligent_PrerenderIo"/> | ||
| <module name="Aligent_PrerenderIo"> | ||
| <sequence> | ||
| <module name="Magento_CatalogStaging"/> |
There was a problem hiding this comment.
Not sure how it was missed previously, but Magento_Catalog should be here as a bare minimum. Possibly others missing, also
|
@aligent-lturner , Thank you for the feedback. I have update the code now. |
Upon merging this feature, the issue "both entity_id and row_id being added to _cl tables when product is edited" will be addressed.
Summary of change
Please see the related issue for more information regarding this issue.