updates by lint

.eslintignore

@@ -0,0 +1,5 @@
+node_modules
+dist
+
+# Lock files
+package-lock.json

.eslintrc.json

@@ -0,0 +1,24 @@
+{
+  "env": {
+    "browser": true,
+    "commonjs": true,
+    "es2021": true
+  },
+  "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
+  "overrides": [],
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": {
+    "ecmaVersion": "latest"
+  },
+  "plugins": ["@typescript-eslint", "prettier"],
+  "rules": {
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        "argsIgnorePattern": "^_",
+        "varsIgnorePattern": "^_",
+        "caughtErrorsIgnorePattern": "^_"
+      }
+    ]
+  }
+}

packages/cloudwatch-rds-alert/app/bin/app.ts

@@ -27,50 +27,46 @@ const WEBHOOK_URL_PARAMETER = process.env.WEBHOOK_URL_PARAMETER as string;
 const ALERT_USERNAME = process.env.ALERT_USERNAME as string;
 const ALERT_CHANNEL = process.env.ALERT_CHANNEL as string;
 
-if (typeof RDSINSTANCES === "string") {
-  var instances = RDSINSTANCES.split(",");
-}
+const instances = RDSINSTANCES.split(",");
 
 export class CloudwatchRDSAlertStack extends Stack {
   constructor(scope: Construct, id: string, props?: StackProps) {
     super(scope, id, props);
 
     const topic = new aws_sns.Topic(this, "SNS");
 
-    for (var i in instances) {
-      const db = aws_rds.DatabaseInstance.fromDatabaseInstanceAttributes(
-        this,
-        instances[i],
-        {
-          instanceEndpointAddress: "garbage value", // Can be an arbitrary value
-          instanceIdentifier: instances[i], // CloudWatch looks out for this value
-          port: 3306, // Can be an arbitrary value
-          securityGroups: [
-            aws_ec2.SecurityGroup.fromLookupById(
-              this,
-              instances[i] + "-sg",
-              `${SECURITYGROUP}`
-            ),
-          ], // SG ID has to be valid
-        }
-      );
-      // Only "Average over 5 minutes" is available, hence one evaluation only before firing the alarm off:
-      // https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds.DatabaseInstance.html#metricwbrcpuutilizationprops
-      const alarm_cpu = new aws_cloudwatch.Alarm(
-        this,
-        instances[i] + "-alarm",
-        {
-          alarmName: instances[i] + " database CPU usage alert", // Notification title if sent to Slack
+    instances.forEach(instance => {
+      {
+        const db = aws_rds.DatabaseInstance.fromDatabaseInstanceAttributes(
+          this,
+          instance,
+          {
+            instanceEndpointAddress: "garbage value", // Can be an arbitrary value
+            instanceIdentifier: instance, // CloudWatch looks out for this value
+            port: 3306, // Can be an arbitrary value
+            securityGroups: [
+              aws_ec2.SecurityGroup.fromLookupById(
+                this,
+                instance + "-sg",
+                `${SECURITYGROUP}`
+              ),
+            ], // SG ID has to be valid
+          }
+        );
+        // Only "Average over 5 minutes" is available, hence one evaluation only before firing the alarm off:
+        // https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds.DatabaseInstance.html#metricwbrcpuutilizationprops
+        const alarm_cpu = new aws_cloudwatch.Alarm(this, instance + "-alarm", {
+          alarmName: instance + " database CPU usage alert", // Notification title if sent to Slack
           evaluationPeriods: 1, // The number of periods over which data is compared to the specified threshold. ( 5 minute )
           datapointsToAlarm: 1, // The number of datapoints that must be breaching to trigger the alarm.
           threshold: 30, // over x %
           metric: db.metricCPUUtilization(),
           treatMissingData: aws_cloudwatch.TreatMissingData.BREACHING,
-        }
-      );
-      alarm_cpu.addAlarmAction(new aws_cloudwatch_actions.SnsAction(topic));
-      alarm_cpu.addOkAction(new aws_cloudwatch_actions.SnsAction(topic));
-    }
+        });
+        alarm_cpu.addAlarmAction(new aws_cloudwatch_actions.SnsAction(topic));
+        alarm_cpu.addOkAction(new aws_cloudwatch_actions.SnsAction(topic));
+      }
+    });
 
     const notifySlack = new aws_lambda_nodejs.NodejsFunction(
       this,

packages/cloudwatch-rds-alert/app/handlers/notifySlack.ts

@@ -5,10 +5,10 @@ const WEBHOOK_URL_PARAMETER = process.env.WEBHOOK_URL_PARAMETER as string;
 const ALERT_USERNAME = process.env.ALERT_USERNAME as string;
 const ALERT_CHANNEL = process.env.ALERT_CHANNEL as string;
 
-const AWS = require("aws-sdk");
+import * as AWS from "aws-sdk";
 const SSM = new AWS.SSM();
 // var responseFromSSM = null;
-var parameter = {
+const parameter = {
   Name: WEBHOOK_URL_PARAMETER,
   WithDecryption: true,
 };
@@ -39,8 +39,8 @@ export const getFormattedSlackMessage = (snsMessage: string) => {
 };
 
 interface NotifySlackOutput {
-  event: string;
-  ALERT_CHANNEL: string;
+  event?: string;
+  ALERT_CHANNEL?: string;
   status_code: number;
 }
 
@@ -67,12 +67,14 @@ export const handler = async (
   event: SNSEvent,
   _context: Context
 ): Promise<NotifySlackOutput> => {
-  const functionConfig = await initPromise; // just wait until
+  await initPromise; // just wait until
   const message = getFormattedMessage(ALERT_CHANNEL, event);
   console.log("Message formatted from event: ", message);
   if (!ALERT_CHANNEL) {
     console.log("No alert channel specified - skipping...");
-    return null as any;
+    return {
+      status_code: 400,
+    };
   }
   const response = await sendAlertToChannel(ALERT_CHANNEL, message);
   console.log(

packages/serverless-deploy-iam/test/deploy-role.test.ts

@@ -1,8 +1,6 @@
 import * as cdk from "@aws-cdk/core";
 import {
   expect as expectCDK,
-  matchTemplate,
-  MatchStyle,
   haveResource,
   haveResourceLike,
   countResources,