Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specifically target mesh container for deploy #1398

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

TheOrangePuff
Copy link
Contributor

Description of the proposed changes

  • When nginx is in use, this becomes the default container. However when the mesh deploys we want to target the mesh container. This removes the assumption that the mesh is the default container and instead searches for it.

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

@TheOrangePuff TheOrangePuff force-pushed the fix/mesh-deployment-target-container branch from 8d0dbc6 to c2db060 Compare September 12, 2024 00:53
Copy link
Contributor

@crispy101 crispy101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheOrangePuff TheOrangePuff merged commit 4d62d2a into main Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants