Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerender structured logging #1385

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

gowrizrh
Copy link
Contributor

Description of the proposed changes

  • Add structured logging for prerender. This allows us to store the logs, parse and have visibility on access.

Screenshots (if applicable)
image

@gowrizrh gowrizrh requested review from TheOrangePuff, AdamJHall, crispy101 and a user May 31, 2024 03:40
@gowrizrh gowrizrh force-pushed the feature/DO-1666_prerender_structured_logging branch from 9d3b3c2 to b09bad1 Compare May 31, 2024 03:43
@gowrizrh gowrizrh self-assigned this May 31, 2024
@gowrizrh gowrizrh added the enhancement New feature or request label May 31, 2024
@gowrizrh gowrizrh changed the title DO-1666: Prerender structured logging Prerender structured logging May 31, 2024
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions but looks good!

packages/prerender-fargate/lib/prerender/server.js Outdated Show resolved Hide resolved
@gowrizrh gowrizrh requested a review from TheOrangePuff June 3, 2024 00:30
@gowrizrh
Copy link
Contributor Author

gowrizrh commented Jun 3, 2024

@TheOrangePuff ready for another review 🙂

TheOrangePuff
TheOrangePuff previously approved these changes Jun 3, 2024
// Healthcheck endpoint
server.use({
beforeSend: (req, res, next) => {
if (req.prerender.url === "health") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait nvm, this is good now 😄

@gowrizrh gowrizrh merged commit bd72b65 into main Jun 3, 2024
1 check passed
@gowrizrh gowrizrh deleted the feature/DO-1666_prerender_structured_logging branch June 3, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants