Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-1557: Send 'X-Prerender' HTTP header along with the prerender requests #1144

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

krishanthisera
Copy link
Contributor

Send 'X-Prerender' HTTP header along with the prerender requests


Description of the proposed changes

  • Send 'X-Prerender' HTTP header along with the prerender requests

Screenshots (if applicable)

  • N/A

Other solutions considered (if any)

  • N/A

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question

* This file defines a Prerender server that uses AWS S3 cache to cache prerendered pages.
* It also includes middleware to handle authentication, append a custom header to indicate the response is from Prerender,
* and remove script tags from the prerendered content.
* @requires prerender
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of the @requires syntax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indicates that you need this particular module to run this code. This is just for the documentation.

@krishanthisera krishanthisera merged commit 7e055aa into main Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants