-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO-1545: Prerender Fargate Readme update #1119
DO-1545: Prerender Fargate Readme update #1119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much better than it was before 😍 Just a few minor requests from me
packages/prerender-fargate/README.md
Outdated
|
||
### `enableS3Endpoint` (boolean, optional) | ||
|
||
- Whether to enable the S3 endpoint for the VPC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A link to the AWS docs here would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Prerender Fargate Readme update
Description of the proposed changes
Screenshots (if applicable)
Other solutions considered (if any)
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback