Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO-1545: Prerender Fargate Readme update #1119

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

krishanthisera
Copy link
Contributor

Prerender Fargate Readme update


Description of the proposed changes

  • Prerender Fargate Readme update

Screenshots (if applicable)

  • N/A

Other solutions considered (if any)

  • N/A

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better than it was before 😍 Just a few minor requests from me

packages/prerender-fargate/README.md Show resolved Hide resolved
packages/prerender-fargate/README.md Show resolved Hide resolved

### `enableS3Endpoint` (boolean, optional)

- Whether to enable the S3 endpoint for the VPC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to the AWS docs here would be good

Copy link
Contributor

@crispy101 crispy101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krishanthisera krishanthisera merged commit 7cd67b3 into main Nov 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants