Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLOBAL: enable declration and disable no_emit #1110

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

krishanthisera
Copy link
Contributor

CKD Construct: enable declaration and disable no_emit

Description of the proposed changes

  • This PR set:
...
   "declaration": false,
    "noEmit": true,
...

Which makes the package publish empty, instead revert the change and disable prepublish

Screenshots (if applicable)

  • N/A

Other solutions considered (if any)

  • N/A

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

@krishanthisera krishanthisera merged commit 8b571ee into epic/cdk-v2 Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants