-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerender Fargate: Recaching implementation #1107
Prerender Fargate: Recaching implementation #1107
Conversation
The changes look good to me in general, but can you add the below as we discussed before:
|
@krishanthisera just a comment, can we please keep formatting changes in their own PR? It makes it really hard to tell what has functionally changed Ah, wait, realised you moved props to a new file, not a reformat. Ignore me 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some minor comments but happy for this to go through 🙂
|
||
/** | ||
* Options for configuring the Prerender Fargate construct. | ||
* `PrerenderFargate` construct sets up an AWS Fargate service to run a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool 🙏 We should do this for all our constructs
bucketName, | ||
domainName, | ||
prerenderName, | ||
} = props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like using props.{blah}
makes it clearer to see where the variables are coming from. But maybe that's just me 🤷♂️ If no one else has an issue with this I don't mind 🙂
@crispy101 We shall create two new tickets for the task and add to the epic 🤞 |
Prerender Fargate: Recaching implementation
Description of the proposed changes
@typescript-eslint/no-unused-vars
Screenshots (if applicable)
Other solutions considered (if any)
Notes to PR author
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback