Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/do 1484 enable cache for redirects #1102

Conversation

crispy101
Copy link
Contributor

Description of the proposed changes

  • Fix the bug of not stripping script tags
  • Make user-agent string visible in the logs

Screenshots (if applicable)

Other solutions considered (if any)

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just can't merge into this branch due to the epic/cdkv2 branch

@crispy101
Copy link
Contributor Author

crispy101 commented Dec 5, 2023

Closing this PR without merging as this branch is already merged to the main as part of CDKv2 migration.

@crispy101 crispy101 closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants